Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convert route #64

Closed
wants to merge 5 commits into from
Closed

Add convert route #64

wants to merge 5 commits into from

Conversation

StevenRenaux
Copy link
Collaborator

@StevenRenaux StevenRenaux commented Jun 9, 2024 •
edited by Neirda24
Loading

Closes #63

    #[Route('/convert', name: 'pdf_convert')]
    public function convert(GotenbergPdfInterface $gotenberg): Response
    {
        return $gotenberg->convert()
            ->pdfUniversalAccess()
            ->files('document.pdf')
            ->generate()
            ;
    }

AbstractFormatPdfBuilder could be used everywhere (let me know if we can change in that way) and for #44 and #43

Neirda24
Neirda24 requested changes Jun 10, 2024
View reviewed changes
src/Builder/Pdf/AbstractFormatPdfBuilder.php Outdated Show resolved Hide resolved
src/Builder/Pdf/ConvertPdfBuilder.php Show resolved Hide resolved
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@StevenRenaux
Merge branch 'refs/heads/main' into features/Add-merge-and-metadata-r…
108fd10 
…outes

# Conflicts:
#	config/builder_pdf.php
#	src/Debug/TraceableGotenbergPdf.php
#	src/DependencyInjection/Configuration.php
#	src/DependencyInjection/SensiolabsGotenbergExtension.php
#	src/GotenbergPdf.php
#	src/GotenbergPdfInterface.php
#	tests/DependencyInjection/ConfigurationTest.php
#	tests/DependencyInjection/SensiolabsGotenbergExtensionTest.php
@StevenRenaux StevenRenaux closed this by deleting the head repository Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neirda24 Neirda24 Neirda24 approved these changes

@Jean-Beru Jean-Beru Awaiting requested review from Jean-Beru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implements the convert PDF route
2 participants
@StevenRenaux @Neirda24